Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't report inconsitencies if lifetimes match #135

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Don't report inconsitencies if lifetimes match #135

merged 1 commit into from
Dec 6, 2024

Conversation

kzu
Copy link
Member

@kzu kzu commented Dec 6, 2024

We automatically deduplicate service registrations that are exactly the same, so we don't need to report that case.

@kzu kzu added the enhancement New feature or request label Dec 6, 2024
We automatically deduplicate service registrations that are exactly the same, so we don't need to report that case.
@kzu kzu enabled auto-merge (rebase) December 6, 2024 21:09
@devlooped-bot
Copy link
Member

devlooped-bot commented Dec 6, 2024

37 passed 37 passed

🧪 Details on Ubuntu 22.04.5 LTS

✅ Tests.CodeAnalysis.AddServicesAnalyzerTests.NoWarningIfAddServicesPresent
✅ Tests.CodeAnalysis.AddServicesAnalyzerTests.NoWarningIfNoServiceCollectionCalls
✅ Tests.CodeAnalysis.AddServicesAnalyzerTests.WarnIfAddServicesMissing
✅ Tests.CodeAnalysis.AddServicesAnalyzerTests.WarnIfAddServicesMissingMultipleLocations
✅ Tests.CodeAnalysis.ConventionAnalyzerTests.ErrorIfNonTypeOf
✅ Tests.CodeAnalysis.ConventionAnalyzerTests.NoErrorOnTypeOfAndLifetime
✅ Tests.CodeAnalysis.ConventionAnalyzerTests.NoWarnIfMultipleSameLifetime
✅ Tests.CodeAnalysis.ConventionAnalyzerTests.WarnIfAmbiguousLifetime
✅ Tests.CodeAnalysis.ConventionAnalyzerTests.WarnIfOpenGeneric
✅ Tests.ComponentModel.ComponentModelTests.Composition
✅ Tests.ComponentModel.ComponentModelTests.RegisterSingletonService
✅ Tests.ComponentModel.ComponentModelTests.RegisterTransientService
✅ Tests.ComponentModel.ComponentModelTests.ResolvesDependency
✅ Tests.Composition.CompositionTests.CompositionLifetimes
✅ Tests.Composition.CompositionTests.RegisterKeyedService
✅ Tests.Composition.CompositionTests.RegisterSingletonService
✅ Tests.Composition.CompositionTests.RegisterTransientService
✅ Tests.Composition.CompositionTests.ResolvesDependency
✅ Tests.DependencyInjection.ConventionsTests.RegisterGenericServices
✅ Tests.DependencyInjection.ConventionsTests.RegisterRepositoryServices
✅ Tests.DependencyInjection.ConventionsTests.RegisterServiceByRegex
✅ Tests.DependencyInjection.GenerationTests.RegisterInternalService
✅ Tests.DependencyInjection.GenerationTests.RegisterKeyedScopedService
✅ Tests.DependencyInjection.GenerationTests.RegisterKeyedSingletonService
✅ Tests.DependencyInjection.GenerationTests.RegisterKeyedTransientService
✅ Tests.DependencyInjection.GenerationTests.RegisterScopedService
✅ Tests.DependencyInjection.GenerationTests.RegisterSingletonService
✅ Tests.DependencyInjection.GenerationTests.RegisterTransientService
✅ Tests.DependencyInjection.GenerationTests.RegisterWithCustomServiceAttribute
✅ Tests.DependencyInjection.GenerationTests.RegisterWithGenericOutParameterHierarchy
✅ Tests.DependencyInjection.GenerationTests.ResolveMultipleKeys
✅ Tests.DependencyInjection.GenerationTests.ResolvesDependency
✅ Tests.DependencyInjection.GenerationTests.ResolvesKeyedDependency
✅ Tests.DependencyInjection.GenerationTests.ResolvesKeyedDependencyForNonKeyed
✅ Tests.DependencyInjection.GenerationTests.ResolvesKeyedFromContracts
✅ Tests.DependencyInjection.GenerationTests.ResolvesKeyedTransientDependency
✅ Tests.DependencyInjection.GenerationTests.RetrieveMany

from dotnet-retest v0.6.3 on .NET 8.0.11 with 💜

@kzu kzu merged commit 0517d5e into main Dec 6, 2024
7 checks passed
@kzu kzu deleted the dev/dupe branch December 6, 2024 21:11
@devlooped devlooped locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants