Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposing a new implementation for Range encoding #171

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Proposing a new implementation for Range encoding #171

wants to merge 5 commits into from

Commits on Aug 8, 2018

  1. Added implementation of Encoder for Range 

    The previous implementation was encoding a range as a list of possible
values. This is not a viable approach, as it can possibly lead to huge
messages.
The new implementation treats a range as it is: a map, with a :first and
a :last fields. Thus, the resulting bitstring of Poison.encode(a..b) is
the same as Poison.encode(%{first: a, last: b}).
    Armand committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    846638b View commit details
    Browse the repository at this point in the history

  2. Wrote test for Range encoding

    Armand committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    bdff403 View commit details
    Browse the repository at this point in the history

  3. Removed older implementation for Range

    Armand committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    5350d33 View commit details
    Browse the repository at this point in the history

  4. Fixed integer writing in test Range (underscore style)

    Armand committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    aae7b2f View commit details
    Browse the repository at this point in the history

  5. Ran mix format

    Armand committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    717bc18 View commit details
    Browse the repository at this point in the history