fix: resolve potential None value for filter argument
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapsealk
changed the title
None value for filter argumentNone value for filter argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello graphene-django-filter!
This pull request updates the retrieval of the filter argument to use
or {}to ensure thatfilter_argdefaults to an empty dictionary if the value ofargs.get(settings.FILTER_KEY)isNone, preventing potential errors due to unexpectedNonevalues.Bug Fix:
graphene_django_filter/connection_field.py: Fixed an issue whereargs.get(settings.FILTER_KEY)could returnNone, causing errors. The fix ensures an empty dictionary is used ifNoneis returned.