Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: langchain (original, original-wordmark) #2213

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

kimjiwook0129
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

@Snailedlt Snailedlt changed the title new icon: <i>langchain</i> (<i>original, original-wordmark</i>) new icon: langchain (original, original-wordmark) Jun 13, 2024
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jun 13, 2024
@Snailedlt Snailedlt requested review from a team, ConX, weh, Snailedlt, canaleal and lunatic-fox and removed request for a team June 13, 2024 10:55
Comment on lines +5598 to +5601
"font": [
"original",
"original-wordmark"
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versions used for fonts need to be mono colored, and they need to be as simple as possible (preferably one single path). Please take a look at the wiki to make sure you follow the SVG-Standards and that you're using the correct SVG-Versions

icons/langchain/langchain-original-wordmark.svg Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Error found in "devicon.json" for "langchain" entry: 
- Missing property key: "altnames".

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants