Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: appwrite (original, original-wordmark, plain, plain-wordmark) #2196

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Yashh56
Copy link
Contributor

@Yashh56 Yashh56 commented May 23, 2024

Close #2181

@canaleal canaleal changed the title update icon : appwrite update icon: appwrite (original, original-wordmark, plain, plain-wordmark) Jun 2, 2024
@Yashh56
Copy link
Contributor Author

Yashh56 commented Jun 7, 2024

Hey Maintainer Please Review this PR

@Snailedlt Snailedlt requested review from a team, ConX, weh, Snailedlt, canaleal and lunatic-fox and removed request for a team June 7, 2024 14:54
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

The wordmark versions look very good!

The non-wordmark versions are distorted. Please make sure to keep the aspect ratios the same when resizing the icons, so that they don't become distorted.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this icon has been distorted.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here :)

@Yashh56
Copy link
Contributor Author

Yashh56 commented Jun 7, 2024

Thanks @Snailedlt for reviewing this PR Can you tell me how to resolve this issue ?

@Snailedlt
Copy link
Collaborator

Snailedlt commented Jun 7, 2024

Thanks @Snailedlt for reviewing this PR Can you tell me how to resolve this issue ?

@Yashh56 I think the easiest way is downloading the official icons again and making sure that the aspect ratio is maintained when you resize it :)

If you're using inkscape you can follow this guide when resizing: #1306 (comment)

PS: there's lots of other great guides in that issue as well!

@Yashh56 Yashh56 requested a review from Snailedlt June 8, 2024 11:42
Copy link
Contributor

github-actions bot commented Jun 8, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Yashh56
Copy link
Contributor Author

Yashh56 commented Jun 15, 2024

Hey Maintainer Please Review this PR

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the changes requested by @Snailedlt are still not resolved.
The original and plain version are still squished, and not round anymore.

squished

@weh
Copy link
Contributor

weh commented Jun 17, 2024

...also original and plain could be aliased since it is only a single color (?)

@weh
Copy link
Contributor

weh commented Jun 17, 2024

And i forgot also that the original and plain should not have that much spacing around the icon.
So to summarize again:

  • Fix the squished aspect ratio
  • Remove the spacing around the Icon
  • Remove the plain-wordmark / original-wordmark alias
        "aliases": [
            {
                "base": "plain",
                "alias": "original"
            }
        ]

@Snailedlt
Copy link
Collaborator

Refer to guides under this issue as well as the wiki if you're unsure how to fix the issues :)

@Yashh56
Copy link
Contributor Author

Yashh56 commented Jun 17, 2024

how can i squished aspect ratio ?

@Yashh56
Copy link
Contributor Author

Yashh56 commented Jun 17, 2024

I used Resize to resize the aspect ratio

@Snailedlt
Copy link
Collaborator

@Yashh56 If you're using inkscape, make sure you check the box to scale proportionally
image
Otherwise the svg will get stretched to fit the viewbox.

Here's two different guides to resize to a square. Both can be found as comments in the issue I linked to earlier:

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants