Repository navigation
Conversation
Device.swift.gyb and the generated switches now return (512, 683) for the 13-inch Air models, (41, 59) for iPad Air 11-inch M3 and M4, (417, 605) for iPad Pro 11-inch M4 and M5, and (3, 4) for iPad Pro 13-inch M4 and M5. description and safeDescription for the M2 through M4 Air models and the M4 and M5 Pro models use the unparenthesized size, such as "iPad Air 11-inch (M2)" and "iPad Pro 13-inch (M5)", and those five support links drop /en-us/. The unreleased changelog notes the correction, and the tests assert each portrait ratio on the device and its simulator along with the new descriptions. Fixes devicekit#457. Refs devicekit#457
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Device.swift.gyb and the generated switches now return (512, 683) for the 13-inch Air models, (41, 59) for iPad Air 11-inch M3 and M4, (417, 605) for iPad Pro 11-inch M4 and M5, and (3, 4) for iPad Pro 13-inch M4 and M5. Callers of screenRatio on the 13-inch iPad Air (M2, M3, and M4), the 11-inch iPad Air (M3 and M4), and the 11-inch and 13-inch iPad Pro (M4 and M5) receive a pair whose first component is the larger one, so the value describes a landscape screen.
The DeviceKit module compiles, including the updated generated device table.
Refs #457