ci(gh-actions): resolve zizmor findings#2830
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses Zizmor security findings in the GitHub Actions CI configuration by reducing credential persistence during checkout and avoiding direct shell interpolation of untrusted workflow_dispatch inputs. It also introduces a Zizmor config file to document and suppress an intentional Dependabot cooldown rule finding.
Changes:
- Set
persist-credentials: falseonactions/checkoutacross multiple workflows that don’t need to push to the repo. - Refactor
docker-image.ymlto passworkflow_dispatchinputs via stepenvvariables before use inrun. - Add
.github/zizmor.ymlto ignore thedependabot-cooldownrule (with rationale).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/zizmor.yml | Adds Zizmor configuration to document/ignore an intended rule finding. |
| .github/workflows/api-test.yml | Disables persisted checkout credentials for the API test workflow. |
| .github/workflows/codeql-analysis.yml | Disables persisted checkout credentials for CodeQL workflow. |
| .github/workflows/dependency-review.yml | Disables persisted checkout credentials for dependency review workflow. |
| .github/workflows/docker-image.yml | Disables persisted checkout credentials and avoids direct input interpolation in the shell. |
| .github/workflows/node.js.yml | Disables persisted checkout credentials for Node.js CI workflow. |
| .github/workflows/semantic.yml | Disables persisted checkout credentials for semantic/commit linting workflow. |
| .github/workflows/trivy-scan.yml | Disables persisted checkout credentials for Trivy scan workflow. |
- Set persist-credentials: false on actions/checkout in api-test, codeql-analysis, dependency-review, docker-image, node.js, semantic and trivy-scan; none of these jobs push back to git. - Move the workflow_dispatch docker_registry / docker_tag_name inputs out of the run block and into step env vars in docker-image, so the untrusted values are no longer interpolated into the shell. - Add .github/zizmor.yml ignoring dependabot-cooldown, documenting why daily updates with no cooldown are acceptable here.
madhavilosetty-intel
force-pushed
the
ci/fix-zizmor-findings
branch
from
July 21, 2026 18:17
9ee7e44 to
13a5f4c
Compare
sudhir-intc
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )