fix: avoid popping noise when changing volume #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a little pet peeve of mine. When the volume changes (or is muted/unmuted), a little pop can be heard due to the sudden change. This can be fixed by smoothly increasing/decreasing the volume. This noise is especially audible on tracks like this one: https://www.youtube.com/watch?v=eH-5U7GeofA Weirdly, PulseAudio and PipeWire don't seem to do this internally. Maybe I'll send a patch to PipeWire to fix this, because it's a bit annoying (and there's not much we can do about it in the PulseAudio driver apart from managing volume ourselves).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little pet peeve of mine. When the volume changes (or is muted/unmuted), a little pop can be heard due to the sudden change. This can be fixed by smoothly increasing/decreasing the volume.
This noise is especially audible on tracks like this one: https://www.youtube.com/watch?v=eH-5U7GeofA
Weirdly, PulseAudio and PipeWire don't seem to do this internally. Maybe I'll send a patch to PipeWire to fix this, because it's a bit annoying (and there's not much we can do about it in the PulseAudio driver apart from managing volume ourselves).
So far this is an experiment, and there's a TODO I'd need to fix get this ready for review. But if this is something you'd be interested in, I can continue working on it.