Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMS-964: Add new Eventz api and remove old one. #471

Merged
merged 30 commits into from
Aug 30, 2023
Merged

TMS-964: Add new Eventz api and remove old one. #471

merged 30 commits into from
Aug 30, 2023

Conversation

aerkkilae
Copy link
Contributor

Description

This removes old events api and will be replaced with new Eventz api.

Motivation and Context

Old events api will be closed soon.

How Has This Been Tested?

Local, stage

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the [CONTRIBUTING] document.

@aerkkilae aerkkilae requested a review from a team August 30, 2023 05:32
@ville6000 ville6000 self-assigned this Aug 30, 2023
return $field;
}

$cache_key = 'events-' . $name;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Julkaisun yhteydessä pitää muistaa tyhjentää cache koska key pysyy samana.

lib/Eventz.php Outdated
* Get event location.
*
* @param object $event Event object.
* @param string $lang_key Language key.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kommentin parametrit ja funktion parametrit eivät vastaa toisiaan

{>"views/single-dynamic-event/single-dynamic-event-group-title" title=event.normalized.date_title template_classes=template_classes.info_group_title icon="date" /}
{?event.normalized.recurring}
{?event.normalized.date}
<div class="info-group mb-5 {template_classes.info_group|s}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vanhat escapet käytössä koko tiedostossa. |s -> |attr tai vastaava oikea filtteri

Copy link
Contributor

@ville6000 ville6000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pari huomiota, mutta ok

@aerkkilae aerkkilae merged commit 730ae42 into master Aug 30, 2023
2 checks passed
@aerkkilae aerkkilae deleted the TMS-964 branch August 30, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants