-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TMS-964: Add new Eventz api and remove old one. #471
Conversation
return $field; | ||
} | ||
|
||
$cache_key = 'events-' . $name; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Julkaisun yhteydessä pitää muistaa tyhjentää cache koska key pysyy samana.
lib/Eventz.php
Outdated
* Get event location. | ||
* | ||
* @param object $event Event object. | ||
* @param string $lang_key Language key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kommentin parametrit ja funktion parametrit eivät vastaa toisiaan
{>"views/single-dynamic-event/single-dynamic-event-group-title" title=event.normalized.date_title template_classes=template_classes.info_group_title icon="date" /} | ||
{?event.normalized.recurring} | ||
{?event.normalized.date} | ||
<div class="info-group mb-5 {template_classes.info_group|s}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vanhat escapet käytössä koko tiedostossa. |s -> |attr tai vastaava oikea filtteri
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pari huomiota, mutta ok
Description
This removes old events api and will be replaced with new Eventz api.
Motivation and Context
Old events api will be closed soon.
How Has This Been Tested?
Local, stage
Types of changes
Checklist: