Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add all time view option for analytics #3009

Merged
merged 10 commits into from
Jan 1, 2025
Merged

Conversation

ptdatta
Copy link
Contributor

@ptdatta ptdatta commented Dec 25, 2024

Please indicate what issue this PR is related to and @ any maintainers who are relevant

Fixes #2986

Copy link
Contributor

@skeptrunedev skeptrunedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Granularity needs to change to month

@skeptrunedev skeptrunedev changed the title Added All time feat: add all time view option for analytics Dec 28, 2024
Copy link
Contributor

@skeptrunedev skeptrunedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screencast.from.12-28-2024.10.40.33.AM.webm

image

There are some of functionality issues remaining with this PR.

  • bugfix: I have to click on all time twice for it to take effect
  • bugfix: granularity once all time takes effect is wrong
  • cleanup: last 7 days should also appear in calendar dropdown

@skeptrunedev
Copy link
Contributor

Also, please don't merge and only rebase. I took a few minutes to clean up the commits on this PR to be more inline with our syntax.

@ptdatta
Copy link
Contributor Author

ptdatta commented Dec 29, 2024

Also, please don't merge and only rebase. I took a few minutes to clean up the commits on this PR to be more inline with our syntax.

Sure. Yes, this PR is not ready to merge. I initially thought I needed to change the backend, so I was looking into the server codebase.

@ptdatta
Copy link
Contributor Author

ptdatta commented Dec 29, 2024

@skeptrunedev, will there be any start date for all time?Like the date the dataset was created, or UNIX time 0?

@drew-harris
Copy link
Contributor

"all time" working properly, now doing the backend work to implement month granularity

@drew-harris drew-harris marked this pull request as draft December 29, 2024 23:12
@drew-harris drew-harris marked this pull request as ready for review December 29, 2024 23:20
Copy link
Contributor

@skeptrunedev skeptrunedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever I set the analytics to all time, I get backend server errors which shouldn't happen.

Also, when the backend errors, the granularity on the chart visualization doesn't change.

image

image

@drew-harris
Copy link
Contributor

Closing PR as we are running into issues grouping by month using the clickhouse rust crate. Reopening as draft so that @densumesh can take a look at whats going on with rust crate before we proceed. Thank you @ptdatta for your work!

@drew-harris
Copy link
Contributor

Screen.Recording.2025-01-01.at.3.11.26.PM.mov

@drew-harris drew-harris marked this pull request as ready for review January 1, 2025 21:11
@cdxker cdxker dismissed skeptrunedev’s stale review January 1, 2025 22:10

Changes requested were made

@cdxker cdxker merged commit 9381222 into devflowinc:main Jan 1, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: add 'all time' button for analytics
5 participants