Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: organization name prompt for new users #2254

Merged
merged 5 commits into from
Sep 3, 2024
Merged

feat: organization name prompt for new users #2254

merged 5 commits into from
Sep 3, 2024

Conversation

drew-harris
Copy link
Contributor

Please indicate what issue this PR is related to and @ any maintainers who are relevant

@drew-harris drew-harris marked this pull request as draft August 26, 2024 17:54
@drew-harris drew-harris force-pushed the drewh/signup-org-name branch from 24a0d2e to e21296a Compare August 27, 2024 15:15
@drew-harris drew-harris force-pushed the drewh/signup-org-name branch from 6734f7b to 32de479 Compare August 28, 2024 14:22
@drew-harris drew-harris marked this pull request as ready for review August 28, 2024 16:09
@drew-harris
Copy link
Contributor Author

image

@drew-harris drew-harris mentioned this pull request Aug 28, 2024
Closed
SaraVieira
SaraVieira previously approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't vouch for the rust but FE looks good

@drew-harris drew-harris force-pushed the drewh/signup-org-name branch from 21d308a to 51b1fb3 Compare August 28, 2024 22:11
skeptrunedev
skeptrunedev requested changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@skeptrunedev skeptrunedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't agree with this being a page that blocks access to the entire dashboard. It should be implemented as a fullscreen modal which appears after you get to dash. If the user dismisses it then we should use the default org name.

image

densumesh
densumesh previously requested changes Aug 31, 2024
View reviewed changes
server/src/handlers/auth_handler.rs Outdated Show resolved Hide resolved
@drew-harris drew-harris force-pushed the drewh/signup-org-name branch from 51b1fb3 to 52c581d Compare September 3, 2024 15:52
@drew-harris drew-harris force-pushed the drewh/signup-org-name branch from 523a778 to c59578b Compare September 3, 2024 19:44
@skeptrunedev
Copy link
Contributor

This is a really nice feature

@skeptrunedev skeptrunedev merged commit 7c0dc8d into main Sep 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skeptrunedev skeptrunedev skeptrunedev approved these changes

@densumesh densumesh densumesh left review comments

@SaraVieira SaraVieira SaraVieira left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drew-harris @skeptrunedev @SaraVieira @densumesh