Tf/test window env #1105
Closed
Tf/test window env #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@skeptrunedev
Here's one way of doing what we wanted without rebuilding with vite on a user's machine
it exposes variables by setting them in the window object and using them with an or in solid
node:18 does the building
nginx:1.25.4-alpine-slim is the runtime
The multi-stage build gets rid of node dependencies and extra steps.
The runetime container is 12.3MB with 1.2kb of it being the dist code
Note
needs nginx config and redirect rules
Not sure of behavior if VITE environment variables are also specified