Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile with test virtualizarr branch #10

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

abarciauskas-bgse
Copy link
Contributor

@abarciauskas-bgse abarciauskas-bgse commented Jan 15, 2025

Using branch with temporary fixes to enable use of icechunk writer in VirtualiZarr

@maxrjones maxrjones mentioned this pull request Jan 24, 2025
@abarciauskas-bgse abarciauskas-bgse marked this pull request as ready for review January 24, 2025 17:11
@abarciauskas-bgse
Copy link
Contributor Author

abarciauskas-bgse commented Jan 24, 2025

Lol I forgot I did opened this draft PR 😅 , quoting myself from #13

We can use that branch and it should use the newest icechunk release (currently specified at icechunk>=0.1.0a10 and I just installed that branch on the hub and can verify it installs icechunk==0.1.0a15)

Screenshot 2025-01-24 at 9 10 29 AM

@maxrjones
Copy link
Member

I know you labelled this as [Just for testing] but I'd be in favor of merging this. I think we need to be at the bleeding edge right now, even if it involves branches. would that be alright with you?

@abarciauskas-bgse abarciauskas-bgse changed the title [Just for testing] Update Dockerfile with test virtualizarr branch Update Dockerfile with test virtualizarr branch Jan 24, 2025
@abarciauskas-bgse
Copy link
Contributor Author

@maxrjones

we need to be at the bleeding edge right now, even if it involves branches

definitely seems to be the mode of operation at the moment 😅 so go ahead and merge.

@maxrjones maxrjones merged commit dd05c31 into main Jan 24, 2025
1 check passed
@maxrjones maxrjones deleted the ab/testing-icechunk-upgrade branch January 24, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants