-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global access token setting and validation #735
Add global access token setting and validation #735
Conversation
Dear @DeflateAwning We appreciate the contribution. Adding Auth on top of titiler application should be done at user level. We see
|
I agree that's it's not cut out for every use case, but I maintain that it's a good method method, in cases where the authentication is handled through another system. Managing two authorization tools when TiTiler is being proxied through another API with authentication is ineffective. |
@DeflateAwning can you resolve the issue to make sure the code works with python 3.8 🙏 |
Done! Forgot about that old Python3.8/3.9 type hinting syntax |
@DeflateAwning can you run pre-commit 🙏 |
Hmm, I ran all the content in CONTRIBUTING.md before the Docs section, and then ran |
Fixed. I changed 403 to 401 everywhere applicable (including docs). |
This PR is a feature addition, which allows the addition of a global access token to all endpoints.
This feature is important because it allows implementing a basic security, in cases where the endpoint is routed through a machine-to-machine connection. For example, a Ruby API handles all incoming requests and performs the user permissions validation, and then proxies the requests onto a TiTiler server; no requests from outside the Ruby API should be allowed to access the TiTiler endpoints directly.
Please advise if any changed are required for acceptance of this small feature addition!