Skip to content

Conversation

@hrodmn
Copy link
Contributor

@hrodmn hrodmn commented Oct 15, 2025

I applied the same approach as we did in titiler-multidim (developmentseed/titiler-multidim#103) and it is looking good - the traces/spans are all available in X-Ray and the logging statements are correlated which will make it possible to track performance of specific datasets, features, query patterns.

Here is a preview of an X-Ray trace with the correlated logs at the bottom:
image

@github-actions
Copy link

github-actions bot commented Oct 15, 2025

📚 Documentation preview will be available at: https://developmentseed.github.io/titiler-cmr/pr-previews/pr-81/

Status: ✅ Preview is ready!

github-actions bot pushed a commit that referenced this pull request Oct 15, 2025
github-actions bot pushed a commit that referenced this pull request Oct 15, 2025
github-actions bot pushed a commit that referenced this pull request Oct 15, 2025
github-actions bot pushed a commit that referenced this pull request Oct 15, 2025
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions bot pushed a commit that referenced this pull request Oct 15, 2025
github-actions bot pushed a commit that referenced this pull request Oct 15, 2025
github-actions bot pushed a commit that referenced this pull request Oct 15, 2025
github-actions bot pushed a commit that referenced this pull request Oct 15, 2025
@hrodmn hrodmn marked this pull request as ready for review October 15, 2025 19:29
@hrodmn hrodmn self-assigned this Oct 15, 2025
Copy link
Contributor

@abarciauskas-bgse abarciauskas-bgse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hrodmn ! I would love it if we also got a review from @ividito since I don't have any experience with X-Ray or OpenTelemetry yet. But my only outstanding question is if this effects logging (and how) when open telemetry is not enabled.

Copy link

@ividito ividito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great! I'm super impressed by the Docker solution you put together here, since it also gets around one of the slowest parts of our lambda deployments.

@hrodmn
Copy link
Contributor Author

hrodmn commented Oct 17, 2025

But my only outstanding question is if this effects logging (and how) when open telemetry is not enabled.

Yeah, I need to clean up the logging configuration so that we get all of the logs in local deployments. My initial idea to move everything to handler.py basically eliminated local ogs. Thanks for the suggestion!

github-actions bot pushed a commit that referenced this pull request Oct 17, 2025
github-actions bot pushed a commit that referenced this pull request Oct 17, 2025
github-actions bot pushed a commit that referenced this pull request Oct 17, 2025
@hrodmn hrodmn merged commit b763a3f into develop Oct 20, 2025
7 checks passed
@hrodmn hrodmn deleted the feat/otel branch October 20, 2025 16:45
github-actions bot pushed a commit that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants