Small fix to transform to 4326 #87
Merged
+30
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙏 it would be nice if we could test this |
RemcoMeeuwissen
changed the title
|
Took a few days but this test should be enough, it at least covers the use case where I found the bug 🙂 |
|
🙏 @RemcoMeeuwissen could you add a line in the changelog please Thank you |
|
Didn't realize that there is a changelog now, hope this is clear enough |
vincentsarago
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
We found a small bug where, if the geom is not 4326 it should transform to 4326 but instead the transform uses the SRID which the geom is already in.
Should line 97 also be changed? Because it's also going to use the geom native SRID rather than 4326.