fix: Fix map.set_view_state does not set pitch and bearing #1055
Conversation
Previously, changing pitch and bearing using set_view_state or by clicking and dragging the map did not forward updates to Map.view_state. Added tests to verify. Closes developmentseed#1052
There was a problem hiding this comment.
initially wrote an isMapView() check, as suggested #1052 (comment) but turns out view was always "undefined" when I created my maps with m = viz([])
There was a problem hiding this comment.
I don't know the peculiarities of jupyter widgets, but these tests always passed, even with pitch and bearing specified.
There was a problem hiding this comment.
I added some tests. This was fun to play around with.
Oddly, updating pitch/bearing with set_view_state and then calling view_state in the same cell correctly reflected the changes (in the text output, not on the map) but if view_state was instead called in a subsequent cell, pitch and bearing were not updated. This is my best attempt at testing that behavior, and the manual pitch/bearing adjustment behaviour.
1 participant
Previously, changing pitch and bearing using set_view_state or by clicking and dragging the map did not forward updates to Map.view_state. Added tests to verify.
Closes #1052