fix: Allow setting stac.overrideRootPath to empty string for stac-auth-proxy integration #307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When deploying stac-auth-proxy in front of the eoapi service, users need to set
stac.overrideRootPath
to an empty string to remove the--root-path
argument from the STAC FastAPI application. However, this configuration didn't work because:false
{{- if .Values.stac.overrideRootPath}}
would fail for empty strings.Values.stac.ingress.path
instead of respecting the empty stringSolution
Changed the template logic to use
hasKey
function to check for key existence in deployment.Behavior Change:
.Values.stac.ingress.path
(e.g., "/stac")overrideRootPath: ""
): Omits--root-path
argument entirelyoverrideRootPath: "/custom"
): Uses that specific valueBreaking Changes
None. This change is backward compatible:
overrideRootPath
continue to workoverrideRootPath
continue to workRelated Issues
Fixes #306
@batpad to be tested