Add monitoring

[pantierra]

No description provided.

[claude]

Claude finished @pantierra's task in 3m 32s —— View job

---

Claude finished the review

• Gather context (diff, changed files)
• Review correctness / security / best-practice issues
• Apply ponytail-review pass for over-engineering
• Post final review

---

✅ No blocking issues — safe to merge.

Reviewed the monitoring stack (Prometheus/Grafana overlay, dashboard provisioning, per-service instrument_app/add_metrics wiring, dependency bumps to titiler.pgstac==3.1.0 / stac-fastapi.* / tipg[metrics]), the deploy workflow changes, and the new traffic-simulation scripts. Nothing blocking:

• docker-compose.yml's raster env vars (POSTGRES_* → PG*) correctly line up with the corresponding config.py rename (postgres_host → pghost, etc.) for the new titiler.pgstac version — verified stac/vector still use the old POSTGRES_* prefix intentionally, matching their unchanged settings classes.
• dockerfiles/Dockerfile.browser's switch to git clone --branch ... --depth 1 plus conditional DYNAMIC_CONFIG sed is correct and faster than the old clone+checkout.
• GF_SECURITY_ADMIN_PASSWORD: admin in docker-compose.metrics.yml:39 is static, but the accompanying comment correctly notes it's inert as long as GF_AUTH_BASIC_ENABLED/GF_AUTH_DISABLE_LOGIN_FORM stay off — worth a periodic sanity check if Grafana's auth defaults ever change, but not a merge blocker since it's explicitly called out.
• ACME_EMAIL echoed via crontab -l in install_demo_cron.sh:697/deploy.yaml is a GitHub Actions variable (vars.ACME_EMAIL), not a secret, so there's no real credential leak into CI logs.
• stac-viewer.html's assets=${asset}|bidx=${bidx} param change matches the titiler.pgstac 3.x API (replacing the old separate asset_bidx param) in both the 1-band and 3-band code paths.

Simplify (ponytail)

• scripts/simulate_traffic.py:873-1225 — 15 near-identical scenario_* functions each hand-thread (client, stats, name, method, url, headers, expected) into _request(); replace with a list of (name, method, url_template, headers, expected) tuples run through one generic executor → cuts ~250 lines of repetition.
• scripts/simulate_traffic.py:767-780 — Stats.by_scenario: dict[str, int] with manual .get(x, 0) + 1 under a lock reinvents collections.Counter; Counter() + the same lock reads the same and drops the .get boilerplate.

---

💰 Estimated review cost: $0.75 · 3m32s · 26 turns