Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Add support for preact x #48

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

cristianbote
Copy link
Collaborator

@cristianbote cristianbote commented Aug 28, 2019

This adds support for preact x but depends on this PR from preact preactjs/preact#1901. After that's merged and released we could merge this one as well.

Adds +3.71kB 😞 more than double it's current size
Adds +0.89kB 😄 now we're talking
Adds +0.98kB 🤔

@cristianbote
Copy link
Collaborator Author

This will fail until preactjs/preact#1901 is merged

@cristianbote cristianbote requested a review from developit August 29, 2019 20:35
@cristianbote
Copy link
Collaborator Author

This is gonna be working when preactjs/preact#1924 it's gonna get released

@cristianbote
Copy link
Collaborator Author

Also this updates the react-redux version and redux with the latest ones.

package.json Outdated Show resolved Hide resolved
rollup.config.js Outdated Show resolved Hide resolved
src/compat.js Outdated Show resolved Hide resolved
@developit
Copy link
Owner

Folks will be glad to have this working in X. One question still in my mind though: do we know why aliasing react:preact doesn't work, instead requiring all of compat? I'd really love to quantify that delta.

Awesome pointers!

Co-Authored-By: Jason Miller <[email protected]>
@cristianbote
Copy link
Collaborator Author

Hey @developit that's a great point! Unfortunately it seems that the build size increases if I would add the imports by hand and re-export them. 🤷‍♂

@jahilldev
Copy link

@cristianbote @marvinhagemeister Any ideas on when this might be released? Would really like to upgrade to Preact X.

Many thanks

@cristianbote
Copy link
Collaborator Author

@jhdevuk it's awaiting Jason's review. It's on his todo list 👍

@@ -11,7 +11,7 @@ const babelRc = JSON.parse(fs.readFileSync(".babelrc"));
let pkg = JSON.parse(fs.readFileSync("./package.json"));

let external = Object.keys(pkg.peerDependencies || {}).concat(
Object.keys(pkg.dependencies || {})
Object.keys(pkg.dependencies || {}), 'preact/compat'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including preact/compat completely defeats the purpose of this project, doesn't it? 😿

@adminy
Copy link

adminy commented Dec 9, 2021

Ok, well, what are the alternatives? Where to get Provider and connect from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants