-
Notifications
You must be signed in to change notification settings - Fork 347
[java,java-postgres]- Add support for debian trixie(13) #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[java,java-postgres]- Add support for debian trixie(13) #364
Conversation
|
|
||
| | Options Id | Description | Type | Default Value | | ||
| |-----|-----|-----|-----| | ||
| | imageVariant | Java version (use -bookworm, or -bullseye variants on local arm64/Apple Silicon): | string | 21-bullseye | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest Java LTS is 25. I suggest documenting with the latest GA and LTS version.
brunoborges
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Microsoft Build of OpenJDK 25 is now available and 25 is the latest LTS.
| "type": "string", | ||
| "description": "Java version (use -bookworm, or -bullseye variants on local arm64/Apple Silicon):", | ||
| "proposals": [ | ||
| "21-trixie", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is missing 25-trixie
| | Options Id | Description | Type | Default Value | | ||
| |-----|-----|-----|-----| | ||
| | imageVariant | Java version (use -bookworm, or -bullseye variants on local arm64/Apple Silicon): | string | 21-bullseye | | ||
| | imageVariant | Java version (use -trixie, or -bookworm variants on local arm64/Apple Silicon): | string | 21-trixie | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend 25-trixie (latest LTS)
| "description": "Java version (use -bookworm, or -bullseye variants on local arm64/Apple Silicon):", | ||
| "description": "Java version (use -trixie, or -bookworm, variants on local arm64/Apple Silicon):", | ||
| "proposals": [ | ||
| "21-trixie", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing 25-trixie
| "8-bookworm" | ||
| ], | ||
| "default": "21-bullseye" | ||
| "default": "21-trixie" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default should move to latest LTS, 25-trixie
Ref: https://github.com/devcontainers/internal/issues/283
Devcontainer Templates:
java
java-postgres
Description of changes:
Aims to add support for debian trixie (13)
Changelog:
Change in Dockerfile to add debian trixie image variant
Change in devcontainer-template.json to add debian trixie as the default option.
Change in readme file.
Checklist:
All checks are passed.