Skip to content

Conversation

@gvatsal60
Copy link
Contributor

@gvatsal60 gvatsal60 commented Nov 3, 2024

  • Updated the action to the latest version.
  • Added a customization in devcontainer.json to handle trailing whitespace.
  • Automated Updates: Dependabot will automatically submit pull requests whenever an update is available for any GitHub Actions, reducing manual maintenance work.

@gvatsal60 gvatsal60 requested a review from a team as a code owner November 3, 2024 12:54
@gvatsal60
Copy link
Contributor Author

Hi @bamurtaugh,

I’ve already submitted the PR for #296, but it seems I forgot to link it to the issue. My apologies for the oversight.

@gvatsal60 gvatsal60 mentioned this pull request Dec 18, 2024
@bamurtaugh bamurtaugh requested a review from chrmarti January 6, 2025 17:24
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I don't see us set "editor.trimAutoWhitespace": true in other repositories and I'm not sure how much noise this will generate. Could you omit that?

Omitted `"editor.trimAutoWhitespace": true`
@gvatsal60 gvatsal60 requested a review from chrmarti April 12, 2025 05:27
@gvatsal60
Copy link
Contributor Author

Hey @chrmarti ,

Would you mind reviewing this PR when you get a chance? Your feedback would be really helpful! Let me know if you need any additional context.

Thanks!

@chrmarti
Copy link
Contributor

Thanks for the PR and sorry for the delay! Files Changed on this PR no longer show any changes. Maybe the dependabot updates took care of it?

@gvatsal60
Copy link
Contributor Author

gvatsal60 commented Jun 18, 2025

Thanks for the PR and sorry for the delay! Files Changed on this PR no longer show any changes. Maybe the dependabot updates took care of it?

Thanks for checking! There are still some changes showing in the PR.

Copy link
Contributor

@AlvaroRausell AlvaroRausell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! (and apologies for the delay)

@AlvaroRausell AlvaroRausell removed the request for review from chrmarti October 28, 2025 11:13
@AlvaroRausell AlvaroRausell dismissed chrmarti’s stale review October 28, 2025 11:13

Dismissing as user made the right changes

@AlvaroRausell AlvaroRausell merged commit 30269da into devcontainers:main Oct 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants