Fix yamllint error #250
Closed
Fix yamllint error #250
+280
−261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
Fixed yamllint error excluding following rules. - line-length: Default limit 80 is too small - comments-indentation: This rule is being discussed at adrienverge/yamllint#141 and adrienverge/yamllint#384
|
Previous test run failure on typescript-node was related to firebase/firebase-admin-node#2512, and I believe this is fixed by DefinitelyTyped/DefinitelyTyped#69231. I could not reproduce failure on universal. Test on my machine runs without failure. |
| # package ecosystems to update and where the package manifests are located. | ||
| # Please see the documentation for more information: | ||
| # https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates | ||
| # https://containers.dev/guide/dependabot |
There was a problem hiding this comment.
Looping in @joshspicer for another set of eyes.
If we decide to merge this, you'd need to bump patch versions for all the updated Templates.
eg.
|
Closing as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling dev container in project with
yamllintenabled,yamllintreports errors on some of the dev container template files.Fixed yamllint error including:
But excluded following lint errors: