fix: Improve directory deletion on Windows #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2024 17:54
- Implement custom rmtree function to handle Windows deletion errors - Replace shutil.rmtree calls with new rmtree utility function - Move __onerror handler to utils.py for centralized error handling
- Refactor rmtree function to handle Windows deletion errors - Remove unused shutil imports from multiple files - Add error handling and retry logic for file removal
kagami-l
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves directory deletion on Windows by implementing a custom rmtree function to handle Windows-specific deletion errors. The changes include:
These changes should resolve issues related to directory deletion on Windows systems and improve overall reliability of the deletion process.