-
-
Notifications
You must be signed in to change notification settings - Fork 8
Making a publishing workflow #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Have you tested it? Looks good so far. |
I'm currently doing a last test. 🤞 The rendenring already works, now I'm only testing the Publishing. |
Can you tell me the enviroment variables so I can add them to travis? |
You have to make an Auth token on your account and add it on the Dashboard and name the variable GH_TOKEN |
@skayo I have now access to the Travis repo |
This comment has been minimized.
This comment has been minimized.
Wait if you are a collaborator can you see travis logs and stuff? |
@skayo I'm seeing the log |
okay cool |
This PR was tested and tweaked and works now and is so ready for merging |
I like most of the suggestions here. I'm still unsure about automatically creating the PDF though. Let's check with the others. |
How does it render a PDF? I'm sorry but I've got no clue... |
@gadilashashank It uses the software Pandadoc and TexLive to generate a pdf file |
I'm fine with automatic rendering of a PDF. I might sound a bit noob here but is it possible to mention a guide on how to generate PDF from the markdown because atleast I have never done this before.. |
@gadilashashank We use travis to automatically convert the md files to one single pdf. |
@FilipeRamalho great!! As I said earlier I'm fine with this arrangement of automatic PDF generation.. |
@FilipeRamalho please wait before merging. I want try GitBook first and see how it is |
Gitbook would also be option, but can you host it on GitHub or have multiple collaborators.
|
If this solution isn‘t liked I could instead make a service hook on my server to build a pdf on each commit and to host it. Or also make Travis contact the server to only build on successful builds. |
Yes GitBook integrates with GitHub. |
Either of the arrangements works but it should be made sure that every edit goes through a review process and random edits are not allowed. |
Everything happens through pull request so the review happens there. But we could add editors that are responsible for these PRs. |
We should rather have a maintainer Group which has to confirm the merge and also lint the markdown in travis. |
I apologise for being late to the party. I originally intended to have the writers review eachothers work (peer review). But having a dedicated team sounds like a good idea. For now, I'm leaning towards GitBook. |
I will open up a separate issue to go over the editing team. |
@FilipeRamalho Linting markdown sounds like a good idea! We can definitely do that too. |
This PR includes now a linting workflow and was also linted. This is again ready for merge. |
This way GitHub recognizes this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously approved, but added to officially review.
With this PR the book is auto-generated through the use of pandadoc and Latex. Each chapter is written in Markdown files, which are rendered to pdf on each commit and a book.pdf is added to the repo.