Skip to content

Making a publishing workflow #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2018
Merged

Making a publishing workflow #1

merged 2 commits into from
May 24, 2018

Conversation

FilipeRamalho
Copy link
Contributor

@FilipeRamalho FilipeRamalho commented May 23, 2018

With this PR the book is auto-generated through the use of pandadoc and Latex. Each chapter is written in Markdown files, which are rendered to pdf on each commit and a book.pdf is added to the repo.

@jonasgeiler
Copy link
Member

Have you tested it? Looks good so far.
@ODXT what do you think?

@FilipeRamalho
Copy link
Contributor Author

FilipeRamalho commented May 23, 2018

I'm currently doing a last test. 🤞 The rendenring already works, now I'm only testing the Publishing.
Someome would have to make a Travis Build and set the GH_TOKEN variable in Travis.
I don't know why but I can add Travis to the repo, maybe someome who can should do that.

@jonasgeiler
Copy link
Member

jonasgeiler commented May 23, 2018

Can you tell me the enviroment variables so I can add them to travis?
The repo is linked to my travis account somehow

@jonasgeiler jonasgeiler requested a review from ODXT May 23, 2018 17:55
@FilipeRamalho
Copy link
Contributor Author

You have to make an Auth token on your account and add it on the Dashboard and name the variable GH_TOKEN

@FilipeRamalho
Copy link
Contributor Author

FilipeRamalho commented May 23, 2018

@skayo I have now access to the Travis repo

@jonasgeiler

This comment has been minimized.

@jonasgeiler
Copy link
Member

Wait if you are a collaborator can you see travis logs and stuff?

@FilipeRamalho
Copy link
Contributor Author

@skayo I'm seeing the log

@jonasgeiler
Copy link
Member

okay cool

@FilipeRamalho
Copy link
Contributor Author

This PR was tested and tweaked and works now and is so ready for merging

@ODXT
Copy link
Collaborator

ODXT commented May 23, 2018

I like most of the suggestions here. I'm still unsure about automatically creating the PDF though. Let's check with the others.

@gadilashashank
Copy link
Member

gadilashashank commented May 24, 2018

How does it render a PDF? I'm sorry but I've got no clue...
Edit: I mean I've got an .md say. Do I have to run any command et.al to generate a PDF.?

@FilipeRamalho
Copy link
Contributor Author

@gadilashashank It uses the software Pandadoc and TexLive to generate a pdf file

@gadilashashank
Copy link
Member

I'm fine with automatic rendering of a PDF. I might sound a bit noob here but is it possible to mention a guide on how to generate PDF from the markdown because atleast I have never done this before..

@jonasgeiler
Copy link
Member

@gadilashashank We use travis to automatically convert the md files to one single pdf.
You just commit and it does everything automatically. You don't need to do anything.

@gadilashashank
Copy link
Member

@FilipeRamalho great!! As I said earlier I'm fine with this arrangement of automatic PDF generation..

@jonasgeiler
Copy link
Member

@FilipeRamalho please wait before merging. I want try GitBook first and see how it is

@FilipeRamalho
Copy link
Contributor Author

FilipeRamalho commented May 24, 2018 via email

@FilipeRamalho
Copy link
Contributor Author

FilipeRamalho commented May 24, 2018

If this solution isn‘t liked I could instead make a service hook on my server to build a pdf on each commit and to host it. Or also make Travis contact the server to only build on successful builds.

@jonasgeiler
Copy link
Member

jonasgeiler commented May 24, 2018

Yes GitBook integrates with GitHub.
Editing on GitBook directly is only for upto 2 Collaborators. But using GitHub you can edit everything here and GitBook just publishes it. With an infinite amount of collaborators (as far as I know) .
Also a PDF download.

@gadilashashank
Copy link
Member

Either of the arrangements works but it should be made sure that every edit goes through a review process and random edits are not allowed.
Should a new team called Editors be made?

@jonasgeiler
Copy link
Member

Everything happens through pull request so the review happens there. But we could add editors that are responsible for these PRs.

@FilipeRamalho FilipeRamalho changed the title Adding Travis and more .. Structuring the project and making a workflow May 24, 2018
@FilipeRamalho
Copy link
Contributor Author

We should rather have a maintainer Group which has to confirm the merge and also lint the markdown in travis.

@ODXT
Copy link
Collaborator

ODXT commented May 24, 2018

I apologise for being late to the party.

I originally intended to have the writers review eachothers work (peer review). But having a dedicated team sounds like a good idea.

For now, I'm leaning towards GitBook.
@FilipeRamalho, if we see demand or need to use it in the future, we can open a discussion about it again. Sound good?

@FilipeRamalho
Copy link
Contributor Author

@ODXT If it works out with Gitbook I'm happy, I will look into @skayo repo and implement that in my PR and push I will notify when it's done.

@ODXT
Copy link
Collaborator

ODXT commented May 24, 2018

I will open up a separate issue to go over the editing team.

@FilipeRamalho FilipeRamalho changed the title Structuring the project and making a workflow Making a publishing workflow May 24, 2018
@jonasgeiler
Copy link
Member

@FilipeRamalho Linting markdown sounds like a good idea! We can definitely do that too.

@FilipeRamalho
Copy link
Contributor Author

FilipeRamalho commented May 24, 2018

This PR includes now a linting workflow and was also linted. This is again ready for merge.

@ODXT ODXT merged commit 2a0af05 into devRant-Community:master May 24, 2018
@FilipeRamalho FilipeRamalho added the enhancement New feature or request label May 24, 2018
@ODXT ODXT added this to the Foundation milestone May 26, 2018
Copy link
Collaborator

@ODXT ODXT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously approved, but added to officially review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants