Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTO-BACKPORT release-0.38.0] 10187: fix: cover select all edge cases #10198

Open
wants to merge 1 commit into
base: release-0.38.0
Choose a base branch
from

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Nov 5, 2024

Backport 11a2581 from #10187.

@github-actions github-actions bot requested review from a team as code owners November 5, 2024 21:13
@github-actions github-actions bot requested a review from gt2345 November 5, 2024 21:13
@cla-bot cla-bot bot added the cla-signed label Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 30 lines in your changes missing coverage. Please review.

Project coverage is 54.34%. Comparing base (bb6f140) to head (b584498).
Report is 6 commits behind head on release-0.38.0.

Files with missing lines Patch % Lines
webui/react/src/pages/FlatRuns/FlatRuns.tsx 5.26% 18 Missing ⚠️
webui/react/src/components/LoadableCount.tsx 75.00% 7 Missing ⚠️
...bui/react/src/pages/F_ExpList/F_ExperimentList.tsx 0.00% 3 Missing ⚠️
webui/react/src/components/TableActionBar.tsx 91.30% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.38.0   #10198   +/-   ##
===============================================
  Coverage           54.33%   54.34%           
===============================================
  Files                1259     1259           
  Lines              157328   157337    +9     
  Branches             3642     3652   +10     
===============================================
+ Hits                85483    85501   +18     
+ Misses              71712    71703    -9     
  Partials              133      133           
Flag Coverage Δ
backend 46.10% <ø> (-0.01%) ⬇️
harness 71.14% <ø> (ø)
web 54.32% <60.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
webui/react/src/components/Searches/Searches.tsx 61.58% <100.00%> (-0.13%) ⬇️
webui/react/src/components/TableActionBar.tsx 72.35% <91.30%> (+0.30%) ⬆️
...bui/react/src/pages/F_ExpList/F_ExperimentList.tsx 0.00% <0.00%> (ø)
webui/react/src/components/LoadableCount.tsx 92.55% <75.00%> (-1.77%) ⬇️
webui/react/src/pages/FlatRuns/FlatRuns.tsx 11.16% <5.26%> (-0.05%) ⬇️

... and 2 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant