Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue-id template variable #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add issue-id template variable #29

wants to merge 2 commits into from

Conversation

okdas
Copy link

@okdas okdas commented May 15, 2024

We need to programmatically generate some URLs to point to the different development dashboards (we provision new environment for each PR). issue-id variable would become handy. Will test this change in the near future.

@okdas
Copy link
Author

okdas commented May 18, 2024

Tested here: okdas/test-actions#1 (comment)

@dessant Please let me know if there's anything else needs to be done to get this in. Thanks!

@Olshansk
Copy link

@dessant Bump

@Olshansk
Copy link

Olshansk commented Jun 4, 2024

@okdas Bump #2

@okdas
Copy link
Author

okdas commented Jun 5, 2024

I've discovered this only replaces the first mention of {issue-id}, so we need to change the implementation.
pokt-network/poktroll#567 (comment)

@okdas
Copy link
Author

okdas commented Aug 2, 2024

Modified the replace() calls to use global regular expressions (/g flag) instead of string literals. This ensures all instances of {issue-author} and {issue-id} are replaced, not just the first occurrence.

Here's an example of working global replace: pokt-network/poktroll#702 (comment)

@dessant can we get this in please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants