-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pure-MPI implementation in a Podman container #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a pure-MPI version of
FastSpecFit
, which does not make use ofmultiprocessing
at all. In addition, a given production (e.g., Y3/Loa) can be run entirely out of a Podman container, which gives us full control over the input software stack (see here for details, including the instructions file).In production, parallelism is controlled by
bin/mpi-fastspecfit
. The number of MPI tasks in thempi4py.MPI.COMM_WORLD
communicator (as given bysrun --ntasks=n
) is split intoint(ceil(n/mp))
sub-communicators, wheremp
is the number of desired ranks per sub-communicator. Using therank=0
ranks in the sub-communicators, we parallelize over healpixels; in addition, all the ranks in a given sub-communicator are used to parallelize over objects / targets infastspecfit.fastspec()
. In particular, infastspecfit.fastspec()
we usecomm.send
andcomm.recv
(send and receive) to make sure each rank only sees the data it needs, which should help prevent memory overflow problems.I'll post timing tests shortly. And at the moment, there is one issue that I have not been able to track down, but perhaps others may have some ideas.