Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InMemoryDataset redesign] Optimize fancy indices #388

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Oct 20, 2024

This PR is made of several commits; the first commits are the incorporated PRs listed above. See only final commit for review.

PR contents

  • Simplify fancy indices down to slices whenever possible - first try to do so globally, and if that's not possible try again locally for each chunk. This will produce an immediate benefit even in the legacy as_subchunk_map implementation, as it avoids an expensive intermediate deep-copy.
  • Speed up monotonic ascending fancy indices from O(n^2) to O(n*logn)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant