Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IAM Bindings and Update Documentation #6

Merged

Conversation

IanKnighton
Copy link
Contributor

  • feat: add service account and refactor documentation
  • chore: fix quotations

BREAKING CHANGE

In this update, I added the IAM bindings and supporting variables in order to assign roles/pubsub.publisher and roles/pubsub.publisher to the subscription. This should resolve a warning after creation in the console that the subscription does not have the correct permissions to use the dead letter topic/subscription.

I also:

  • Split off the terraform-docs output into it's own .md file to make the view on the registry more usable.
  • Added a default to the labels variable so it is no longer required. We use it, but that doesn't mean it is required should someone else stumble across it.
  • Drastically updated the documentation to have basic configuration and an example implementation.

BREAKING CHANGE: implements a new property and IAM controls that will not exist in current iterations
clockdude
clockdude previously approved these changes Oct 10, 2024
Copy link

@clockdude clockdude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, documentation

@IanKnighton IanKnighton merged commit 2cfc789 into main Oct 10, 2024
@IanKnighton IanKnighton deleted the feature-create-terraform-module-for-pub-sub-topics-sc-308777 branch October 10, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants