Skip to content

Conversation

@fiwswe
Copy link

@fiwswe fiwswe commented Nov 26, 2025

See #1153

@fiwswe fiwswe changed the title Carify docs Clarify docs Nov 26, 2025
Copy link
Member

@peterthomassen peterthomassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one minor nit. Also, can you change the commit title to start with the usual syntax and be more prescriptive? e.g.: "feat(docs): clarify dynDNS query parameters, closes #1153" or something.

(The last addition will cause the issue to be closed when this PR is merged.)

or AAAA records. To achieve this, append the prefix length to the IP address
query parameter, such as ``ipv6=2a01:a:b:c::1/64``.
query parameter, such as ``ipv6=2a01:a:b:c::/64``, ``myipv4=1.2.3.0/24``, etc.
The host part of the prefix is ignored.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prefix has no host part :-)

Suggested change
The host part of the prefix is ignored.
The host part of the value is ignored.

As suggested the prefix has no host part.
@fiwswe fiwswe changed the title Clarify docs feat(docs): clarify dynDNS query parameter usage Nov 27, 2025
@fiwswe
Copy link
Author

fiwswe commented Nov 27, 2025

Sorry, I found no way to change the commit message of the first commit. If needed I'll withdraw the PR and create a new one. Please let me know.

@peterthomassen
Copy link
Member

In general, you can change the commit message of the most recent commit by using git commit --amend.

If you have several commits, you can use git rebase -i origin/main to do various things with commits you added, including changing their messages, squashing them etc.

Does that help?

@fiwswe
Copy link
Author

fiwswe commented Nov 27, 2025

Not really as I am only using the GitHub web interface. And it does not offer this option.

Also from what I understand the --amend option can potentially cause issues. The commit message seems to be included in the internal hash git calculates. So it should be considered immutable.

The only clean option I see is to start over and create a new PR.

BTW: Is your naming scheme for commits documented anywhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants