-
-
Notifications
You must be signed in to change notification settings - Fork 59
feat(docs): clarify dynDNS query parameter usage #1170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just one minor nit. Also, can you change the commit title to start with the usual syntax and be more prescriptive? e.g.: "feat(docs): clarify dynDNS query parameters, closes #1153" or something.
(The last addition will cause the issue to be closed when this PR is merged.)
docs/dyndns/update-api.rst
Outdated
| or AAAA records. To achieve this, append the prefix length to the IP address | ||
| query parameter, such as ``ipv6=2a01:a:b:c::1/64``. | ||
| query parameter, such as ``ipv6=2a01:a:b:c::/64``, ``myipv4=1.2.3.0/24``, etc. | ||
| The host part of the prefix is ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prefix has no host part :-)
| The host part of the prefix is ignored. | |
| The host part of the value is ignored. |
As suggested the prefix has no host part.
|
Sorry, I found no way to change the commit message of the first commit. If needed I'll withdraw the PR and create a new one. Please let me know. |
|
In general, you can change the commit message of the most recent commit by using If you have several commits, you can use Does that help? |
|
Not really as I am only using the GitHub web interface. And it does not offer this option. Also from what I understand the The only clean option I see is to start over and create a new PR. BTW: Is your naming scheme for commits documented anywhere? |
See #1153