promise_core, multipromise: clean-up

dermesser · Oct 8, 2024 · 4ad12f1 · 4ad12f1
1 parent 6afacfc
commit 4ad12f1
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 10 deletions.
diff --git a/uvco/loop/scheduler.cc b/uvco/loop/scheduler.cc
@@ -1,14 +1,12 @@
 // uvco (c) 2023 Lewin Bormann. See LICENSE for specific terms.
 
-#include <array>
 #include <fmt/core.h>
 #include <uv.h>
 
 #include "uvco/loop/scheduler.h"
 
 #include <algorithm>
 #include <coroutine>
-#include <cstddef>
 #include <span>
 
 namespace uvco {
@@ -44,9 +42,6 @@ void Scheduler::runAll() {
       // filter, because it takes fewer calculations and is a nice linear search
       // over a usually short vector.
       if (findFirstIndexOf(resumableRunning_, coro) == i) {
-        // This is only true if the coroutine is a false positive in the bloom
-        // filter, and has not been run before. The linear search is slow (but
-        // not too slow), and only happens in the case of a false positive.
         coro.resume();
       }
     }

diff --git a/uvco/promise/multipromise.cc b/uvco/promise/multipromise.cc
@@ -1,3 +1,5 @@
+// uvco (c) 2024 Lewin Bormann. See LICENSE for specific terms.
+
 #include "uvco/promise/multipromise.h"
 
 namespace uvco {}
diff --git a/uvco/promise/multipromise.h b/uvco/promise/multipromise.h
@@ -1,3 +1,4 @@
+// uvco (c) 2024 Lewin Bormann. See LICENSE for specific terms.
 
 #pragma once
 
@@ -54,10 +55,6 @@ template <typename T> class MultiPromiseCore : public PromiseCore<T> {
     PromiseCore<T>::state_ = PromiseState::waitedOn;
   }
 
-  /// See `Promise::resume`. Implemented here to provide a distinction in stack
-  /// traces.
-  void resume() override { PromiseCore<T>::resume(); }
-
   /// Resume the generator from its last `co_yield` point, so it can yield the
   /// next value.
   ///

diff --git a/uvco/promise/promise_core.h b/uvco/promise/promise_core.h
@@ -123,7 +123,7 @@ template <typename T> class PromiseCore : public RefCounted<PromiseCore<T>> {
   /// enqueuing it in the global event loop.
   ///
   /// A promise core can only be resumed once.
-  virtual void resume() {
+  void resume() {
     if (handle_) {
       BOOST_ASSERT(state_ == PromiseState::waitedOn);
       state_ = PromiseState::resuming;