Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested fix for issue #27 #29

Closed
wants to merge 6 commits into from
Closed

Suggested fix for issue #27 #29

wants to merge 6 commits into from

Conversation

isotopp
Copy link

@isotopp isotopp commented Aug 26, 2015

This is a fix for the myid issues referenced in issue #27 and in issue #18.

You can now specify an ensemble as a hash of hashes, and it will generate stable, manually assigned myid files, and a stable server.i ensemble where .i and the myid generated will match.

Parameter wiring needs cleaning up (currently using a global hiera hash sys11stack::ensemble, needs to be changed so that the parameter actually can be chosen).

@deric
Copy link
Owner

deric commented Sep 16, 2015

Ok, interesting approach, it doesn't really automate assging IDs. So, what would the configuration look like?

zookeeper:servers:
  'foo':
     'myid': 1
     'ip': '192.168.1.1'
     'election_port': 1234
     'leader_port': 1244
     'observer': true

you don't actually use the key of the hash, right?

@isotopp
Copy link
Author

isotopp commented Sep 20, 2015

You cannot automatically assign the ids, because they need to be stable. If you automate it and later change the config, it will break your existing ZK setup. Since ZK is stateful (that's the whole purpose of the component) this is not acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants