Typescript conversion #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment, add some additional types to methods
…text (singleton compontnts do not call super)
ericyhwang
reviewed
Oct 23, 2023
src/App.ts
Outdated
| @@ -37,11 +37,11 @@ interface AppOptions { | |||
| scriptHash?: string, | |||
| } | |||
|
|
|||
| type OnRouteCallback = (arg0: Page, arg1: Page, model: Model, params: any, done?: () => void) => void; | |||
| type OnRouteCallback<T = object> = (arg0: Page, arg1: Page, model: ChildModel<T>, params: PageParams, done?: () => void) => void; | |||
There was a problem hiding this comment.
I suggest using just Model here, as the routes receive page.model, which is a root model - instance of the base class Model in racer.
Most other places should be ok with just Model too since Derby doesn't really use the internal underscore-prefixed ChildModel fields.
ericyhwang
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.