Make menu foreground style configurable through skins #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertgustavsson
force-pushed
the
1875-make-menu-foreground-brighter
branch
from
8ba42ec
to
f63ce92
Compare
albertgustavsson
changed the title
derailed
reviewed
Nov 29, 2024
There was a problem hiding this comment.
@albertgustavsson Nice! Thank you for this update. I think we should add some docs on this feature in the README to list out the text style options.
|
@derailed I added a small note to the README about the new skin property. Please review and get back to me if you think more in-depth documentation is necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1875
Gives better control through skins to help make the menu text readable.
The skin property k9s.frame.menu.fgStyle sets the text style to either "dim", "bold" or "normal" (default is dim to not break existing skins)