Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort containers in index order #2878

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Sort containers in index order #2878

wants to merge 14 commits into from

Commits on Sep 12, 2024

  1. Add container IDX column 

    Add a new index column for containers, which is the index in either the InitContainer or Containers.
    @ryanbrainard
    ryanbrainard committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b12b5ef View commit details
    Browse the repository at this point in the history

  2. Set container IDX as default sort column

    @ryanbrainard
    ryanbrainard committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1748dd2 View commit details
    Browse the repository at this point in the history

  3. Drop redundant INIT column

    @ryanbrainard
    ryanbrainard committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b13ab6b View commit details
    Browse the repository at this point in the history

  4. Use index for getContainerStatus look up to avoid name collisions

    @ryanbrainard
    ryanbrainard committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    55806e0 View commit details
    Browse the repository at this point in the history

  5. Add TestContainerRes_IndexLabel

    @ryanbrainard
    ryanbrainard committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    35580f4 View commit details
    Browse the repository at this point in the history

  6. Resolve codebeat issues: 

    - render.ContainerRes: too many instance variables
- dao.makeContainerRes: Too many function arguments

By changing Container and Status fields into methods that read from Pod
    @ryanbrainard
    ryanbrainard committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2af813b View commit details
    Browse the repository at this point in the history

  7. codebeat: remove optional args from MakeContainerRes

    @ryanbrainard
    ryanbrainard committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0e70b11 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Revert "codebeat: remove optional args from MakeContainerRes" 

    This reverts commit 0e70b11.
    @ryanbrainard
    ryanbrainard committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3b95b12 View commit details
    Browse the repository at this point in the history

  2. Revert "Resolve codebeat issues:" 

    This reverts commit 2af813b.
    @ryanbrainard
    ryanbrainard committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    7d52a91 View commit details
    Browse the repository at this point in the history

  3. Pre-compute container index

    @ryanbrainard
    ryanbrainard committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3c96b3d View commit details
    Browse the repository at this point in the history

  4. Pre-extract container status

    @ryanbrainard
    ryanbrainard committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4e3856a View commit details
    Browse the repository at this point in the history

  5. Flesh out TestContainerList

    @ryanbrainard
    ryanbrainard committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    a20ab06 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Handle container list when ContainerStatus is not set yet

    @ryanbrainard
    ryanbrainard committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a448118 View commit details
    Browse the repository at this point in the history

  2. Revert change to make container id the index, as it breaks container … 

    …logs
    @ryanbrainard
    ryanbrainard committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2a8e7c4 View commit details
    Browse the repository at this point in the history