Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving contours below water and other layers #205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexandervlpl
Copy link

Many thanks to all contributors for this amazing style!

This PR prevents contour lines from being drawn over water (lakes, oceans, etc).

contours-water
(before)

after
(after)

  1. This looks sloppy, like a rendering mistake.
  2. Users of topo maps might think these are bathymetric contours, but they are not. ASTER/SRTM data is not intended for this. It includes very little underwater terrain and these patches are probably very inaccurate.
  3. "Professional" topo maps style and label bathymetric contours differently from land ones. Example:
    water-contours

It would be cool and useful to include a real bathymetric layer in the future! Until then I think these land contours should not appear over water layers.

This also addresses #203 (contours over buildings).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant