Skip to content

feat: deprecate filter-solid, map new icon using filter #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

scurker
Copy link
Member

@scurker scurker commented Aug 12, 2025

closes #2057

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2058.d15792l1n26ww3.amplifyapp.com

@scurker scurker marked this pull request as ready for review August 13, 2025 14:18
@Copilot Copilot AI review requested due to automatic review settings August 13, 2025 14:18
@scurker scurker requested a review from a team as a code owner August 13, 2025 14:18
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a deprecation strategy for the filter-solid icon by mapping it to the existing filter icon. The changes introduce a temporary mapping mechanism to consolidate similar icons before addressing the broader iconography system.

  • Adds a MAPPED_TYPES mapping object to redirect filter-solid to filter
  • Updates the build script to include non-SVG icon types in the TypeScript definitions
  • Maintains backward compatibility while preparing for icon consolidation

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/react/src/components/Icon/index.tsx Implements icon mapping logic to redirect filter-solid to filter icon
packages/react/scripts/buildIconTypes.js Updates type generation to include additional mapped icon types

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@scurker scurker requested a review from a team August 14, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "filter" icon with the one used for "filter-solid"
1 participant