New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set status code to 404 for the not found page #244

Merged

robjtede merged 1 commit into main from not-found-404

Jan 9, 2025

Member

paolobarbolini commented Dec 30, 2024

https://deps.rs/aaaa currently misleadingly returns 200.


          fix: set status code to 404 for the not found page

693c4d0

paolobarbolini requested a review from robjtede

December 30, 2024 12:10

Member Author

paolobarbolini commented Jan 9, 2025

Enet4 approved these changes

View reviewed changes

Contributor

Enet4 left a comment

Not my specialty, but according to the docs on the Responder trait, that change looks correct.

robjtede approved these changes

View reviewed changes

robjtede merged commit 7fe6aaf into main

4 checks passed

robjtede deleted the not-found-404 branch

January 9, 2025 10:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet