✨ 다른 앱에서 스트릿드랍으로 공유하는 Share Extension 기능 추가 #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…고 서버통신을 통해 주소 찍어줌 - 그 외 몇가지 UI들만 추가
…usic Array 첫번째 인덱스값 앨범커버, 노래이름, 아티스트이름 UI에 표시
… Share Extension 앱타겟 추가
- Share Extension에서는 UIApplication.shared.open(url) 사용 불가능해서 SFSafariViewController로 노션페이지 띄움
- 기존 드랍하기 버튼 이외에, 텍스트뷰 클릭해서 키보드 올라올때, 키보드 바로위에 드랍하기 버튼 추가
…WithMaxCount 키값 1로 설정해서 한 번에 하나의 웹 URL만 수락하도록 함 - NSExtensionActivationSupportsWebURLWithMaxCount: 이 키는 확장이 웹 URL을 수락하고 처리할 수 있다는 것을 나타냄. 값은 최대 몇 개의 웹 URL을 한 번에 지원할 수 있는지를 나타내는 정수로 설정
… 공유된 곡이름 통해 검색 및 테이블 뷰 데이터들 나타냄
- 기존 데이터는 뒤에 "- TOPIC' 접미어가 붙어 검색 정확도가 떨어졌음
…시, 테이블뷰에 빈배열(빈화면) 보여줌
- 원래 changingMusicView 클릭 할때만 이벤트 발생해야함
- '음악 검색하기'버튼 클릭 시, 빈 테이블뷰의 재검색 화면으로 이동
- 정상 동작을 위한 재기동을 위해 팝업 확인 버튼 클릭 시, Share Extension 종료
…없는 경우(음악 정보 못가져온 경우) 딜레이없이 빠르게 관련 UI 렌더링
…ion과 App간의 App Groups를 설정
… 필요하기 때문에 앱의 드랍하기 로직과 분기
…랍한 아이템에 대한 커뮤니티 Scene에서 렌더링 - Share Extension에서 드랍한 아이템 ID, UserDefaults에 저장 및 메인 Scene ViewDidAppear 또는 Bakcground -> Foreground 전환 시 커뮤니티 Scene 렌더링
thoonk
reviewed
Aug 26, 2024
|
|
||
| layoutIfNeeded() | ||
|
|
||
| let contentContainerHeight = 16 + 48 + 33 + commentLabel.actualNumberOfLines() * 20 + 46 |
There was a problem hiding this comment.
어떤 컴포넌트의 height인지 상수로 선언되어 있으면 더 좋겠네요..! (유지보수를 위하여,,)
thoonk
reviewed
Aug 27, 2024
Comment on lines
103
to
107
| private lazy var searchCancelView: UIView = { | ||
| let view: UIView = .init() | ||
|
|
||
| return view | ||
| }() |
There was a problem hiding this comment.
Suggested change
| private lazy var searchCancelView: UIView = { | |
| let view: UIView = .init() | |
| return view | |
| }() | |
| private lazy var searchCancelView: UIView = .init() |
Comment on lines
33
to
37
| private let warningImageView: UIImageView = { | ||
| let imageView: UIImageView = .init(image: .init(named: "warning")) | ||
|
|
||
| return imageView | ||
| }() |
There was a problem hiding this comment.
Suggested change
| private let warningImageView: UIImageView = { | |
| let imageView: UIImageView = .init(image: .init(named: "warning")) | |
| return imageView | |
| }() | |
| private let warningImageView: UIImageView = .init(image: .init(named: "warning")) |
| func bindAction() { | ||
| searchTextField.rx.text.orEmpty | ||
| .filter { $0.isEmpty } | ||
| .map { _ in } |
There was a problem hiding this comment.
Suggested change
| .map { _ in } |
|
|
||
| sceneDelegate.navigateToCommunity(with: shareExtensionDroppedItemID) | ||
| sharedDefaults.removeObject(forKey: "ShareExtensionDroppedItemID") | ||
| sharedDefaults.synchronize() |
There was a problem hiding this comment.
synchronize() 메서드는 공식 레퍼런스에서도 사용하지 않는 것을 권장하고 있습니다!
참고
wendoei
approved these changes
Sep 4, 2024
Comment on lines
103
to
107
| private lazy var searchCancelView: UIView = { | ||
| let view: UIView = .init() | ||
|
|
||
| return view | ||
| }() |
Comment on lines
29
to
31
| override func setSelected(_ selected: Bool, animated: Bool) { | ||
| super.setSelected(selected, animated: animated) | ||
| } |
|
|
||
| communityGuideButton.rx.tap | ||
| .bind { [weak self] in | ||
| guard let self = self else { return } |
There was a problem hiding this comment.
옵셔널 제거 단축 syntax 로 써도 될거같아요~!
https://github.com/swiftlang/swift-evolution/blob/main/proposals/0345-if-let-shorthand.md
Suggested change
| guard let self = self else { return } | |
| guard let self else { return } |
Comment on lines
99
to
101
| } onFailure: { owner, error in | ||
|
|
||
| } |
|
|
||
| func navigateToCommunity(with itemID: Int) { | ||
| let sceneDelegate = UIApplication.shared.connectedScenes | ||
| .first!.delegate as? SceneDelegate |
There was a problem hiding this comment.
지금도 type 이 SceneDelegate? 라서 first? 로 써도 될거같아요~
| let sceneDelegate = UIApplication.shared.connectedScenes | ||
| .first!.delegate as? SceneDelegate | ||
|
|
||
| if let navigationView = topViewController(base: sceneDelegate?.window!.rootViewController)? |
joseph704
force-pushed
the
feature/region-filtering
branch
from
d932c53 to
49432e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 배경
close #297
내용
테스트 방법 (optional)
스크린샷 (optional)
RPReplay_Final1724291345-2.MP4
RPReplay_Final1724291387-2.MP4