Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 로그 추적을 용이하게 하기 위한 MDC 적용 #419

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

penrose15
Copy link
Collaborator

@penrose15 penrose15 commented Sep 11, 2024

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • 로그 추적을 위해 MDC를 추가하였습니다.
  • MDCFilter를 통해 모든 요청에 대해 request_id 가 붙게 됩니다. (request_id는 클라이언트의 IP 로 임시로 지정해놓았습니다.)
  • 추후 Nginx request_id를 활용하는 방법으로 업그레이드를 해보겠습니다

📝 참고사항

적용 결과 (도커 데스크톱 로그 출력)
KakaoTalk_20240911_223805312

@penrose15 penrose15 requested review from its-sky and ywonchae1 and removed request for its-sky September 11, 2024 12:45
Copy link

github-actions bot commented Sep 11, 2024

Test Results

64 tests   64 ✅  2s ⏱️
17 suites   0 💤
17 files     0 ❌

Results for commit c2142b2.

♻️ This comment has been updated with latest results.

Copy link
Member

@its-sky its-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~ 그런데 캡처 예시에서는 IPv4가 아니라 IPv6로 나오는거 같은데 왜 그런건가요?

@penrose15 penrose15 merged commit c347042 into develop Sep 11, 2024
2 checks passed
@its-sky its-sky deleted the refactor/353-mdc branch September 13, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ 멀티 스레드 에서도 로그 추적을 쉽게 하기 위해 MDC 적용
2 participants