Skip to content

feat: add reclaim functionality for volume purchasing locations #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

neilmartin83
Copy link
Contributor

Change

Thank you for your contribution !
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Adds ReclaimVolumePurchasingLocationByID function so we can programatically deal with situations where a VPP token is used in a different instance or Jamf Pro flags it as such (sometimes it's flagged incorrectly).

Also runs that function during a create and update for belt/braces. This ensures token creation/renewal will always result in the MDM server owning that token afterwards, making sure licenses are available without manual intervention needed for these edge cases. We have observed the reclaim banner appearing on creation/renewal in some cases, even for newly generated tokens. This works around the issue successfully.

The reclaim endpoint always returns a 202 response, even if the reclaim is not needed. There is no harm in doing this.

Type of Change

Please DELETE options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)
  • Refactor (refactoring code, removing code, changing code structure)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • x ] My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@neilmartin83 neilmartin83 requested a review from ShocOne as a code owner May 21, 2025 19:02
@neilmartin83 neilmartin83 changed the title Nm-volumepurchasinglocations-2025-05-21 feat: add reclaim functionality for volume purchasing locations May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant