Skip to content

fix: mobile device applications - various #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

neilmartin83
Copy link
Contributor

@neilmartin83 neilmartin83 commented May 19, 2025

Change

Thank you for your contribution !
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Various fixes as a result of investigating why some mobile device app settings wouldn't change/update/set. :-)

  • Set bools to pointers to ensure they are not empty if set to false
  • Correct struct hierarchy - moved scope, vpp and others out of general and into root level
  • Add missing field keep_app_updated_on_devices
  • Updated examples to handle bool pointers
  • Ensure we return the app ID after create (it's not in the root of the XML structure, same as ldapservers...)
  • Refactored scope structs to match mobile device profiles

Type of Change

Please DELETE options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)
  • Refactor (refactoring code, removing code, changing code structure)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@neilmartin83 neilmartin83 requested a review from ShocOne as a code owner May 19, 2025 20:04
@neilmartin83 neilmartin83 changed the title Nm-mobiledeviceapplications-2025-05-19 fix: mobile device applications - various May 19, 2025
@neilmartin83 neilmartin83 marked this pull request as draft May 20, 2025 08:14
@ShocOne ShocOne merged commit 5791e63 into deploymenttheory:main May 29, 2025
2 of 4 checks passed
@neilmartin83 neilmartin83 deleted the nm-mobiledeviceapplications-2025-05-19 branch May 29, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants