Skip to content

Adjust concurrency logic and metrics in the concurrency package #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

ShocOne
Copy link
Contributor

@ShocOne ShocOne commented Apr 23, 2024

Change

Reviewed and Adjusted Metric Calculations: Ensured that the error rate calculation is accurate and represents a meaningful metric for scaling decisions. This might include:
Averaging error rates over a rolling window of requests rather than accumulating persistently.
Resetting the error count on successful requests or adjusting how much weight is given to older errors.
Improve Logging: Enhance logging to provide more transparency about why decisions are made, especially around scaling. Log entries should reflect the success of ongoing operations and not just the status of previous errors unless those are directly relevant.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ShocOne ShocOne merged commit bdb2091 into main Apr 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant