-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to manually specify addtional CPE entries to be checked. #361
Conversation
f408dab
to
89a639a
Compare
I have some larger work to complete in the core library before I can review this PR. |
No worries! I appreciate you having a look. I've used these changes locally but would be nice not to have to maintain our own separate build. Hopefully it's a useful feature for others. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor changes will help with some of the reports.
src/main/groovy/org/owasp/dependencycheck/gradle/tasks/AbstractAnalyze.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/org/owasp/dependencycheck/gradle/tasks/AbstractAnalyze.groovy
Show resolved
Hide resolved
Co-authored-by: Jeremy Long <[email protected]>
Thanks. I've committed those changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Had to push a fix to get your changes in properly 😞 Can you review again please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sorry about the delay - this is being released today. I've unfortunately had a ton of other work outside of my OSS contributions consuming my time. Thanks again for the PR. |
This change allows adding CPEs to be included in analysis for dependencies that might not be picked up during scans.
For example to add in a dependency on PostgresSQL: