-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Bump npm version from 10.9.3 to 11.6.2 latest #13482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| NPM_V8 = "8" | ||
| NPM_V9 = "9" | ||
| NPM_V10 = "10" | ||
| NPM_V11 = "11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test that validates that this works?
ie:
Using
"engines": {
"npm": ">=11.0.0"
}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thavaahariharangit Please review github/docs#41144 as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test that validates that this works?
ie:
Using
"engines": { "npm": ">=11.0.0" }
Test added: b846671
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thavaahariharangit Please review github/docs#41144 as well
I have approved this PR, It's a draft PR, we need to wait @yeikel to update this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the test 🙏
And yes, as soon as this change is merged, I'll move the docs pull request to ready
|
I am happy with this changes, I will merge and deploy with this changes. |
yeikel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now. Thanks!
What are you trying to accomplish?
In my previous PR update, I updated the Dockerfile. However, I overlooked some related changes, which I’ve now addressed in this update.
Anything you want to highlight for special attention from reviewers?
I've addressed @yeikel's feedback in this comment.
Regarding the question about Node 22 and NPM 11 compatibility (reference):
How will you know you've accomplished your goal?
I reproduced the original error in this workflow: GitHub Actions run, where the updater defaulted to installing
npm@10.After applying the update, the local logs now show that the correct version
[email protected]is being installed and used, confirming that the engine constraints are being properly processed and the issue is resolved.Checklist