Support ruby style requirements as gradle requirements #11764
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This change addresses the comment found in both gradle and maven requirement types
A requirement like
> 1.2.3+0.1.1
can be provided as part of an ignore condition from a chat command like@dependabot ignore
. The string contains a dynamic version and without this change will end up being translated to~> > 1.2.3+0.1.1
with dual operators making it an invalid requirement.If a caller has already provided an operator as part of the requirement, it seems like we should be respecting that and not overwriting it. The java version classes seems to work fine with comparisons between dynamic versions.
Anything you want to highlight for special attention from reviewers?
Is there any case where a dynamic requirement string could be used with a non-gradle requirement or version class? If Gradle's requirement class ever passes off the requirement as a string to
Gem::Version
for example, this change would be incorrect.How will you know you've accomplished your goal?
@dependabot ignore
works on a gradle or maven dependency with a dynamic versionChecklist