consider project target framework for package update eligibility #11485
+83
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
commented
Feb 5, 2025
| if (!d.TargetFramework.IsAny) | ||
| { | ||
| tfms.Add(d.TargetFramework); | ||
| } | ||
| } | ||
|
|
||
| var refItems = await readers.ContentReader.GetReferenceItemsAsync(cancellationToken); |
There was a problem hiding this comment.
This was pulled out of the above loop because it's possible for a NuGet package to not list any dependency groups, but still have values in the lib/ directory that need to be considered.
brettfo
commented
Feb 5, 2025
| nugetContext, | ||
| logger, | ||
| CancellationToken.None); | ||
| if (isTfmCompatible || projectTfms.IsEmpty) |
There was a problem hiding this comment.
This is the actual fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires a simultaneous merge of PR dependabot/smoke-tests#255
This PR has a temporary commit that redirects the smoke tests to the changes in the above linked PR
When considering a package as an update candidate, we need to consider the original project's target framework. We already have the values and just need to forward them through to a framework checker utility that we already have. The only weird instance is when considering updates to repo-level packages specified in
dotnet-tools.jsonorglobal.json; those have no project target framework so we have to consider an empty framework list as always compatible.