Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial dotnet_sdk updater #10756

Merged
merged 12 commits into from
Nov 1, 2024
Merged

Initial dotnet_sdk updater #10756

merged 12 commits into from
Nov 1, 2024

Conversation

JamieMagee
Copy link
Contributor

@JamieMagee JamieMagee commented Oct 8, 2024 •
edited
Loading

What are you trying to accomplish?

Add support for .NET SDK updates in global.json. Closes #2442.

Anything you want to highlight for special attention from reviewers?

Related PRs:

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

This was referenced Oct 8, 2024
Merged
Merged
@JamieMagee JamieMagee force-pushed the jamiemagee/dotnet-sdk branch 5 times, most recently from 6c3cbaa to f901eab Compare October 8, 2024 23:12
@JamieMagee JamieMagee marked this pull request as ready for review October 8, 2024 23:20
@JamieMagee JamieMagee requested a review from a team as a code owner October 8, 2024 23:20
@JamieMagee JamieMagee force-pushed the jamiemagee/dotnet-sdk branch 3 times, most recently from 3056363 to aaea1be Compare October 15, 2024 19:41
@thavaahariharangit thavaahariharangit merged commit 0d9864e into main Nov 1, 2024
125 checks passed
@thavaahariharangit thavaahariharangit deleted the jamiemagee/dotnet-sdk branch November 1, 2024 17:20
@rhyskoedijk rhyskoedijk mentioned this pull request Nov 11, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richlander richlander richlander left review comments

@martincostello martincostello martincostello left review comments

@thavaahariharangit thavaahariharangit thavaahariharangit approved these changes

@brettfo brettfo brettfo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for updating the .NET Core SDK specified by global.json
5 participants
@JamieMagee @brettfo @martincostello @richlander @thavaahariharangit