Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat -pre version suffix as prerelease. #10207

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

dbrant
Copy link
Contributor

@dbrant dbrant commented Jul 13, 2024

What are you trying to accomplish?

Certain projects release packages with pre-release versions that have a suffix of -preN, which doesn't seem to get caught by dependabot as a prerelease, and gets submitted in a pull request as a stable package.

example prerelease:
https://github.com/maplibre/maplibre-native/releases/tag/android-v11.0.2-pre0

example erroneous pull request:
wikimedia/apps-android-wikipedia#4806

@dbrant dbrant requested a review from a team as a code owner July 13, 2024 15:08
@github-actions github-actions bot added the L: java:maven Maven packages via Maven label Jul 13, 2024
@abdulapopoola
Copy link
Member

Thanks a lot @dbrant , could you please add a test and we can get this over the line :)

@github-actions github-actions bot added the L: java:gradle Maven packages via Gradle label Jul 13, 2024
@dbrant
Copy link
Contributor Author

dbrant commented Jul 13, 2024

Thanks a lot @dbrant , could you please add a test and we can get this over the line :)

whoops, of course -- how about now?

@abdulapopoola abdulapopoola merged commit 3147bb1 into dependabot:main Jul 15, 2024
43 checks passed
@abdulapopoola
Copy link
Member

Merged and deployed! Thanks @dbrant !!

@deivid-rodriguez
Copy link
Contributor

For what it's worth, we discussed this in the past at #6747 and decided not to deviate from what maven documents at https://maven.apache.org/pom.html#Version_Order_Specification. And -pre is not mentioned at all in there.

Funny enough, when we rejected adding "-preview", I actually mentioned "-pre" explicitly:

That said, I also feel package authors should stick to what their package manager supports, and not use their own versioning. Because now if another package author decides to name their prerelease versions as "pre", then we'll need to support that and when that stops?

@deivid-rodriguez
Copy link
Contributor

Well, it was not really a clear decision, I totally understand taking the pragmatic approach over the correct, consistent one. Just saying that if we decide to do this, we may also want to reopen #6747.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: java:gradle Maven packages via Gradle L: java:maven Maven packages via Maven
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants